Fix type of Tasty.Type.TypeSelect.prefix #4682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we did not support type trees as prefixes
To make it easier to consume the API.
nicolasstucki
force-pushed
the
fix-typeselect
branch
from
c837495 to
a3b2486
Compare
|
|
|
|
liufengyun
approved these changes
Jun 19, 2018
|
|
||
| object TypeSelect extends TypeSelectExtractor { | ||
| def unapply(x: TypeTree)(implicit ctx: Context): Option[(TypeTree, String)] = x match { | ||
| case x: tpd.Select @unchecked if x.isType && x.qualifier.isType => Some(x.qualifier, x.name.toString) | ||
| case _ => None | ||
| } |
There was a problem hiding this comment.
I find the name a little misleading, what about TypeProject? Then we can keep using TypeSelect as before.
There was a problem hiding this comment.
Users would write the extractors as Type.TypeSelect(_, _) and Type.TermSelect(_, _). We should have a pass on all names later to make sure all names are good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we did not support type trees as prefixes